From 42e609321472f3796f010a1d32a39785c4328576 Mon Sep 17 00:00:00 2001 From: sinanmohd Date: Mon, 15 Apr 2024 20:57:55 +0530 Subject: libnpass/util: refactor https://www.kernel.org/doc/html/v4.10/process/coding-style.html - Function return values and names (-Exxx = failure, 0 = success) for imperative commands (0 = failure, non-zero = success) for predicates --- src/libnpass/libnpass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/libnpass/libnpass.c') diff --git a/src/libnpass/libnpass.c b/src/libnpass/libnpass.c index 6c66a79..94a0647 100644 --- a/src/libnpass/libnpass.c +++ b/src/libnpass/libnpass.c @@ -269,7 +269,7 @@ int pass_init(const char *fpr) err_ret(1, "key not usable, try gpg --full-generate-key"); r = r_mkdir(pass_dir, S_IRWXU); - if (r) + if (r < 0) err_ret(1, "%s %s", pass_dir, strerror(errno)); r = snprintf(gpg_id_path, sizeof(gpg_id_path), "%s/%s", pass_dir, @@ -436,5 +436,5 @@ int pass_rm(const char *path) if (r) err_ret(1, "%s %s", abs_path, strerror(errno)); - return r_rmdir(pass_dir, dirname(gpg_path)); + return r_rmdir_empty(pass_dir, dirname(gpg_path)); } -- cgit v1.2.3