aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* avoid doing dynamic allocation for bar buffers (#279)N-R-K2022-06-012-13/+8
| | | | | | | | just use a static buffer since the size is constant and doesn't change. as opposed to using malloc, this also sets the buffer's initial memory region to 0 by default. also remove BAR_{L,R}_LEN from nsxiv.h, not needed after commit b4268fbf38d1f8433c73999466e116e68c7f81e7
* Makefile: add utf8.h as window.o dependency (#280)N-R-K2022-05-311-1/+1
| | | | unlikely for utf8.h to change, other than syncing with upstream, but doesn't hurt tracking it either ways.
* Makefile: use lowercase for internal macrosNRK2022-05-302-10/+12
| | | | ref: 971f5d669490696c11f5c4ede1fee558e05ae4fc
* config.mk: use c99 as default CCNRK2022-05-301-1/+3
| | | | | See https://github.com/nsxiv/nsxiv/issues/262#issuecomment-1111216349 for related discussion.
* config.mk: add comments for OpenBSD usersNRK2022-05-302-1/+10
| | | | Closes: https://github.com/nsxiv/nsxiv/issues/262
* introduce config.mkNRK2022-05-303-35/+35
| | | | | | | this moves all the build variables intended to be modified by the user over to `config.mk` similar to other suckless software. also move CPPFLAGS down below for cosmetic purposes.
* fix: broken slideshow if redraw takes too long (#282)N-R-K2022-05-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently the way check_timeout() is implemented, animate has higher priority than slideshow. so if doing a redraw takes longer than the frame delay of the animated image then it's going to continuously keep animating and never reliably get to slideshow. this issue can occur if the animated image has too fast of a delay or if nsxiv is being run on a slow system where doing redraw takes too long. the issue can be emulated by artificially slowing down img_render by sticking a sleep in there. diff --git a/main.c b/main.c index 5dc52d4..0580011 100644 --- a/main.c +++ b/main.c @@ -441,6 +441,7 @@ void redraw(void) if (mode == MODE_IMAGE) { img_render(&img); + nanosleep(&(struct timespec){0, 62000000}, NULL); /* 62ms */ if (img.ss.on) { t = img.ss.delay * 100; if (img.multi.cnt > 0 && img.multi.animate) make it so that slideshow has higher priority than animate to fix the issue. Closes: https://github.com/nsxiv/nsxiv/issues/281
* fix: broken statusbar after key-handler cancellationNRK2022-05-191-25/+6
| | | | | | | | | | | | | | | | | | | to reproduce: 1. have an image-info script 2. invoke the key-handler 3. cancle invocation by pressing `escape` at this point, the statusbar ends up being empty. the regression seems to be caused by 6922d5d (changing select to poll), unsure why that is. in any case, this simplifies read_info quite a bit and solves the regression as well. in short: * read straight into the statusbar buffer * if read succeeds, make sure buffer is null terminated and replace any newline with space * close the script
* fix: don't override statusbar if info script doesn't existNRK2022-05-191-1/+1
| | | | | | | this happens when the keyhandler is invoked while viewing an animated image. if {image,thumb}-info scripts exists, everything works as expected. but if they don't, then update_info will override the statusbar.
* fix: broken thumbnail statusbar after running keyhandlerNRK2022-05-191-2/+2
|
* check_timeouts: avoid unnecessary conversions (#273)N-R-K2022-05-122-10/+4
| | | | | | | | before we were using select, which expected `struct timeval` as arg. so we needed to do ms -> timeval conversions. but now since we're using poll, which accepts milisec as arg, there's no need to do ms -> timeval -> ms. instead have check_timeouts directly return ms.
* Declare every extern function/variable in `nsxiv.h` (#268)N-R-K2022-05-037-48/+53
| | | | | | | | with a couple exceptions as they cause too many -Wshadow warnings. also moves the `extcmd_t` typedef on top for cosmetic purposes. also enable `-Wmissing-prototypes` in the ci
* Add thumb-info (#265)N-R-K2022-05-035-19/+69
| | | | Closes: https://github.com/nsxiv/nsxiv/issues/88 Closes: https://github.com/nsxiv/nsxiv/pull/253
* replace select() with poll() (#270)N-R-K2022-04-282-18/+14
| | | | | | | | | | usage of select (3) in modern programs is typically discouraged. this simply replaces the select call with poll (3) instead. and since poll conveniently ignores negative fds, this also reduces needs for some special casing. this also handles error if they occur, while old implementation didn't. other than the error handling, no change in functionality should occur.
* README: some wording change and cosmetics (#269)N-R-K2022-04-281-6/+8
|
* merge autoreload_{inotify,nop}.c into autoreload.c (#263)explosion-mental2022-04-273-45/+30
|
* code-style: reduce some unnecessary if-elses (#261)N-R-K2022-04-272-16/+5
| | | | also change the condition inside img_frame_animate() to check for positive value rather than comparing against 0.
* Update .desktop entry's mimetypes (#260)Michael2022-04-171-1/+1
| | | Co-authored-by: NRK <nrk@disroot.org>
* don't quit if imlib_create_image() fails (#248)N-R-K2022-04-121-2/+8
| | | | | ...simply print an error msg and try (slower) fallback. also adds a useful comment explaining why we're doing manual blending.
* fix: correctly close the font (#250)N-R-K2022-04-101-2/+3
| | | | | | | currently we immediately close the font on win_init_font(), which was introduced in 0d8dcfd. this was probably not correct since we use `font` later in win_draw_text(). instead, the font should be closed at exit/cleanup.
* Improve starting in fullscreen modeKim Woelders2022-03-311-3/+6
| | | | | | Instead of effectively first mapping the window at regular size and then fullscreening it, tell the WM to map the window at fullscreen size by setting _NET_WM_STATE_FULLSCREEN before mapping the window.
* Correct setting of _NET_WM_PIDKim Woelders2022-03-311-2/+2
| | | | | | | The property _NET_WM_PID is a CARDINAL which per definition has format 32, whatever the size of pid_t may be. CARDINALS (and other format 32 items) must always be passed to Xlib in long's, whatever the size of long may be.
* fix: thumbnail memory leak when removing file (#247)N-R-K2022-03-271-0/+4
|
* Fix typo and manpage improvement (#249)Nick Morrott2022-03-262-16/+27
| | | | | | | * Fixes some typo and adds some consistency to the manpage Typo detected automatically whilst packaging nsxiv for Debian Co-authored-by: NRK <nrk@disroot.org>
* fix: close the file descriptor in get_win_title() (#245)N-R-K2022-03-171-0/+1
| | | | this would eventually end up opening too many fds and erroring out with "too many open files".
* Export known issues in readme to GitHub issues (#243)Berke Kocaoğlu2022-03-081-4/+1
| | | Export known issues in readme to GitHub issues and link the issue
* Release version 29N-R-K2022-03-033-2/+32
|
* fix: window title not working on certain WMsNRK2022-03-022-11/+12
| | | | | | | not all WMs support `_NET_WM_NAME` and `_NET_WM_ICON_NAME` this patch sets `WM_NAME` and `WM_ICON_NAME` inside win_set_title() Closes: https://github.com/nsxiv/nsxiv/issues/233
* always initialize window titleNRK2022-03-023-21/+27
| | | | | before if exec/win-title didn't exist then window title wouldn't be set. this patch makes it so window title is always set to something.
* code-style: slight cleanupsNRK2022-03-024-8/+8
| | | | | | * put TOP_STATUSBAR under the HAVE_LIBFONTS guard * change get_win_title param to take unsigned char ptr * init UTF8_STRING like other atoms
* Makefile: cleanup non-posix stuff (#225)N-R-K2022-02-272-29/+24
| | | | | | | | | | remove some non-posix extensions which slipped through and adjust ci to new Makefile changes users can still overwrite the variables explicitly by using `make VAR=VALUE` packagers can also add extra libs to LDLIBS, we're internally using NSXIV_LDLIBS now.
* add config.h option for top statusbar (#231)N-R-K2022-02-265-5/+11
| | | | Closes: https://github.com/nsxiv/nsxiv/issues/230 Co-authored-by: mamg22 <45301823+mamg22@users.noreply.github.com>
* Add libXft-bgra to FAQ in readme (#229)Berke Kocaoğlu2022-02-251-0/+5
| | | | | | Co-authored-by: NRK <nrk@disroot.org> Co-authored-by: eylles <ed.ylles1997@gmail.com> Co-authored-by: explosion-mental <explosion0mental@gmail.com> Co-authored-by: mamg22 <marcomonizg@gmail.com>
* use win-title script for customizing window title (#213)N-R-K2022-02-238-69/+103
| | | | | this removes the cli flag `-T` as well as related config.h options. Co-authored-by: Berke Kocaoğlu <berke.kocaoglu@metu.edu.tr>
* Add reuseable abstraction over fork/exec/dup2 (#211)N-R-K2022-02-203-45/+113
|
* Fix broken ci and enable higher level optimization (#220)N-R-K2022-02-201-0/+6
| | | | | | | | | * [ci] fix broken ci * [ci] enable higher optimization level and lto higher optimization levels enable more warnings and deeper analysis. likewise, lto can catch a couple errors which typically goes unnoticed without it.
* declare internal variables as staticNRK2022-02-171-4/+4
|
* code-style: prefer calloc over malloc+memsetNRK2022-02-174-7/+15
|
* update copyright yearNRK2022-02-138-8/+8
|
* Add keybind to scroll to image center (#203)Nick Hanley2022-01-156-0/+20
| | | There are keybinds for scrolling to the edges of an image but there's no way back to the center. This is particularly annoying while zooming.
* make thumbnail bindings configureable via config.h (#167)N-R-K2022-01-104-53/+82
| | | | | | | | | | | | | | this allows for configuring thumbnail mode mouse bindings similar to image mode bindings. however we can't put the thumbnails bindings into the existing buttons[] array due to fallthrough. For example M3 would switch mode and then end up selecting an image. which is why thumbnail bindings have been put into it's own array `buttons_tns[]` and `buttons[]` has been renamed to `buttons_img[]` for consistency. Closes: https://github.com/nsxiv/nsxiv/issues/131
* Document development workflow for maintainers (#202)mamg222022-01-081-0/+36
| | | | Co-authored-by: NRK <nrk@disroot.org> Co-authored-by: Berke Kocaoğlu <berke.kocaoglu@metu.edu.tr>
* [ci] separate dep from buildNRK2022-01-061-9/+13
| | | | | removes /dev/null redirections from the dep step so in case some dep fails to install/compile we will have the log.
* [ci] fetch tcc from a known working commitNRK2022-01-061-5/+7
| | | | avoids our ci failing in case there's a faulty new commit on tcc.
* add additional warning and -Werror to github workflowNRK2022-01-061-0/+18
|
* fix -Wwrite-strings related warningsNRK2022-01-061-4/+6
|
* fix tcc warningNRK2022-01-061-0/+1
|
* fix -Wmaybe-uninitialized warningNRK2022-01-061-1/+1
|
* fix -Wstrict-prototype warningNRK2022-01-061-1/+1
| | | | looks like i missed one in ff88908
* fix -Wshadow related warningsNRK2022-01-063-11/+10
| | | | | | | | fixes all -Wshadow related warnings (on gcc). this would allow us to use `-Wshadow` in github workflow (https://github.com/nsxiv/nsxiv/pull/195). i've thought about adding `-Wshadow` to our Makefile as well, but decided against it to keep the Makefile CFLAGS barebore/minimal.