From 5c3a796e55a2de822692810d0ac77c6589b0f10e Mon Sep 17 00:00:00 2001 From: NRK Date: Fri, 17 Jun 2022 22:16:37 +0600 Subject: [ci]: slience some clang-tidy warnings the warnings on r_readdir(), img_load_gif() and strcpy seems to be false positives. the warning about fmt being unused is valid, but not worth fixing with additional #ifdef guards. use `assert` to silence the false positive cases when possible, otherwise use a NOLINT comment with an explanation. --- image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'image.c') diff --git a/image.c b/image.c index 2f469b1..bcefa54 100644 --- a/image.c +++ b/image.c @@ -21,6 +21,7 @@ #define INCLUDE_IMAGE_CONFIG #include "config.h" +#include #include #include #include @@ -262,6 +263,7 @@ static bool img_load_gif(img_t *img, const fileinfo_t *file) *ptr = bgpixel; } } else { + assert(cmap != NULL); r = cmap->Colors[rows[i-y][j-x]].Red; g = cmap->Colors[rows[i-y][j-x]].Green; b = cmap->Colors[rows[i-y][j-x]].Blue; @@ -447,7 +449,7 @@ bool img_load(img_t *img, const fileinfo_t *file) exif_auto_orientate(file); #endif - if ((fmt = imlib_image_format()) != NULL) { + if ((fmt = imlib_image_format()) != NULL) { /* NOLINT: fmt might be unused, not worth fixing */ #if HAVE_LIBGIF if (STREQ(fmt, "gif")) img_load_gif(img, file); -- cgit v1.2.3