From a54d99a9307d677af00cc2cf7568a6758d57981a Mon Sep 17 00:00:00 2001 From: kubersharma001 Date: Wed, 15 Dec 2021 17:06:48 +0000 Subject: veux: Don't inherit updatable_apex.mk This is because of the following reasons: - Many build scripts force disable it anyways by settings OVERRIDE_TARGET_FLATTEN_APEX env flag so why bother rendering differences in official and local builds [1][2]. - Compressed apex causes issues with OTA on A only devices [3]. - Compressed apex may cause issues on devices which do not meet kernel requirements [4]. - Highly anticipated mainline modules update aka Play System updates is limited to OEMs/Pixels only [5], we don't do such things on AOSP; shipping Pixel prebuilt apex components feels somewhat unethical. Ref: [1]: https://github.com/lineageos-infra/build-config/blob/8e435ce7ff7c74097b3500e143380273e099aefb/android/build.sh#L9 [2]: https://github.com/LineageOS/android_build/blob/lineage-18.1/target/product/updatable_apex.mk#L19 [3]: RecoverySystemService: Failed to reserve space for compressed apex [4]: https://source.android.com/devices/tech/ota/apex#kernel-requirements [5]: "pushed to end-user devices, either by Google (using the Google Play Store infrastructure) or by the Android partner (using a partner-provided OTA mechanism)." as stated in https://source.android.com/devices/architecture/modular-system#architecture test: m, boots and ota. Change-Id: I5b5c2366398791100fa2222ef779ca4d90842211 --- device.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/device.mk b/device.mk index 3ce40e6..c5c5126 100644 --- a/device.mk +++ b/device.mk @@ -7,9 +7,6 @@ # Inherit from vendor blobs $(call inherit-product, vendor/xiaomi/veux/veux-vendor.mk) -# APEX's -$(call inherit-product, $(SRC_TARGET_DIR)/product/updatable_apex.mk) - # GSI Keys $(call inherit-product, $(SRC_TARGET_DIR)/product/gsi_keys.mk) -- cgit v1.2.3