aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjamin <acdimalev@gmail.com>2021-12-29 09:07:17 -0800
committersinanmohd <pcmsinan@gmail.com>2023-01-12 08:21:56 +0530
commit6cc35936befd8bfea0c58b13270e30628c04932c (patch)
treebc429bbf2da05fc4042d3904e0dd7f6f4c8c8f8a
parente937b5ac4bfdddd4da6a3b8f0e986b5c9faeef57 (diff)
Fix overtyping wide characters.
Overtyping the first half of a wide character with the second half of a wide character results in display garbage. This is because the trailing dummy is not cleaned up. i.e. ATTR_WIDE, ATTR_WDUMMY, ATTR_WDUMMY Here is a short script for demonstrating the behavior: #!/bin/sh alias printf=/usr/bin/printf printf こんにちは!; sleep 2 printf '\x1b[5D'; sleep 2 printf へ; sleep 2 printf ' '; sleep 2 echo
-rw-r--r--st.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/st.c b/st.c
index 0edf8f2..f3af82b 100644
--- a/st.c
+++ b/st.c
@@ -2569,6 +2569,10 @@ check_control_code:
if (width == 2) {
gp->mode |= ATTR_WIDE;
if (term.c.x+1 < term.col) {
+ if (gp[1].mode == ATTR_WIDE && term.c.x+2 < term.col) {
+ gp[2].u = ' ';
+ gp[2].mode &= ~ATTR_WDUMMY;
+ }
gp[1].u = '\0';
gp[1].mode = ATTR_WDUMMY;
}